linux-kernel - Re: [PATCH] power/ds2760_battery: Add rated capacity of the hx4700 3600mAh battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Nov 2011 19:16:03 +0100
From:	Philipp Zabel <philipp.zabel@...il.com>
To:	Paul Parsons <lost.distance@...oo.com>
Cc:	linux-kernel@...r.kernel.org, mad_soft@...ox.ru,
	koen@...inion.thruhere.net, cbouatmailru@...il.com
Subject: Re: [PATCH] power/ds2760_battery: Add rated capacity of the hx4700
 3600mAh battery

On Wed, Nov 23, 2011 at 11:37 PM, Paul Parsons <lost.distance@...oo.com> wrote:
> Add rated capacity of the HP iPAQ hx4700 3.7V 3600mAh (359114-001) battery.
> For this battery the value of the rated capacity EEPROM register at 0x32 is 14;
> thus rated_capacities[14] = 3600.
>
> Signed-off-by: Paul Parsons <lost.distance@...oo.com>
> ---
> diff -uprN clean-3.2-rc2/drivers/power/ds2760_battery.c linux-3.2-rc2/drivers/power/ds2760_battery.c
> --- clean-3.2-rc2/drivers/power/ds2760_battery.c        2011-11-15 17:02:59.000000000 +0000
> +++ linux-3.2-rc2/drivers/power/ds2760_battery.c        2011-11-23 22:06:46.816841888 +0000
> @@ -95,7 +95,11 @@ static int rated_capacities[] = {
>        2880,   /* Samsung */
>        2880,   /* BYD */
>        2880,   /* Lishen */
> -       2880    /* NEC */
> +       2880,   /* NEC */
> +#ifdef CONFIG_MACH_H4700
> +       0,
> +       3600,   /* HP iPAQ hx4700 3.7V 3600mAh (359114-001) */
> +#endif

Is that #ifdef needed? I know there's another one a few lines up, but
I think that one is already unfortunate and there is no conflict here.

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/