linux-kernel - Re: [PATCH] crypto: serpent-sse2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Nov 2011 10:35:29 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	linux-next@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: serpent-sse2 - should select CRYPTO_CRYPTD

On 11/23/2011 10:37 PM, Jussi Kivilinna wrote:
> Since serpent_sse2_glue.c uses cryptd, CRYPTO_SERPENT_SSE2_X86_64 and
> CRYPTO_SERPENT_SSE2_586 should be selecting CRYPTO_CRYPTD.
> 
> Reported-by: Randy Dunlap <rdunlap@...otime.net>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@...et.fi>

Acked-by: Randy Dunlap <rdunlap@...otime.net>

Thanks.

> ---
>  crypto/Kconfig |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 16e0c13..b8d1b10 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -770,6 +770,7 @@ config CRYPTO_SERPENT_SSE2_X86_64
>  	tristate "Serpent cipher algorithm (x86_64/SSE2)"
>  	depends on X86 && 64BIT
>  	select CRYPTO_ALGAPI
> +	select CRYPTO_CRYPTD
>  	select CRYPTO_SERPENT
>  	help
>  	  Serpent cipher algorithm, by Anderson, Biham & Knudsen.
> @@ -787,6 +788,7 @@ config CRYPTO_SERPENT_SSE2_586
>  	tristate "Serpent cipher algorithm (i586/SSE2)"
>  	depends on X86 && !64BIT
>  	select CRYPTO_ALGAPI
> +	select CRYPTO_CRYPTD
>  	select CRYPTO_SERPENT
>  	help
>  	  Serpent cipher algorithm, by Anderson, Biham & Knudsen.
> 


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/