linux-kernel - Re: [PATCH 2/9] ftrace: Fix possible NULL dereferencing in __ftrace_hash_rec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Nov 2011 11:24:05 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	fweisbec@...il.com, mingo@...hat.com, paulus@...ba.org,
	acme@...stprotocols.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] ftrace: Fix possible NULL dereferencing in
 __ftrace_hash_rec_update

On Sun, 2011-11-27 at 19:04 +0100, Jiri Olsa wrote:
> We need to check the existence of the other_hash before
> we touch its count variable.
> 
> This issue is hit only when non global ftrace_ops is used.
> The global ftrace_ops is initialized with empty hashes.
> 
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> ---
>  kernel/trace/ftrace.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index b1e8943..c6d0293 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -1372,7 +1372,8 @@ static void __ftrace_hash_rec_update(struct ftrace_ops *ops,
>  			if (filter_hash && in_hash && !in_other_hash)
>  				match = 1;
>  			else if (!filter_hash && in_hash &&
> -				 (in_other_hash || !other_hash->count))
> +				 (in_other_hash ||
> +				  !other_hash || !other_hash->count))

Thanks! I hit this bug in too many places. I need to make a helper
routine, which I think I will, that is:

	hash_has_contents(hash)

that does the check for us.

-- Steve

>  				match = 1;
>  		}
>  		if (!match)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/