linux-kernel - Re: [PATCH] kexec: do not call kmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Nov 2011 14:27:02 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Dave Young <dyoung@...hat.com>
Cc:	kexec@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kexec: do not call kmsg_dump in crashdump

Dave Young <dyoung@...hat.com> writes:

> mtd/ram oops dumper will make more functions envolved. In case crash kexec, 
> we should avoid kmsg dumper to ensure crashdump success.
>
> kill kmsg_dump callback while crash dumping 

Agreed.

There is a similar?  Or possibly the same patch already queued in
Andrews tree.

Eric

>
> Signed-off-by: Dave Young <dyoung@...hat.com>
> ---
>  kernel/kexec.c |    2 --
>  1 file changed, 2 deletions(-)
>
> --- linux-2.6.orig/kernel/kexec.c	2011-11-18 16:34:18.000000000 +0800
> +++ linux-2.6/kernel/kexec.c	2011-11-24 16:05:08.138660500 +0800
> @@ -1094,8 +1094,6 @@ void crash_kexec(struct pt_regs *regs)
>  		if (kexec_crash_image) {
>  			struct pt_regs fixed_regs;
>  
> -			kmsg_dump(KMSG_DUMP_KEXEC);
> -
>  			crash_setup_regs(&fixed_regs, regs);
>  			crash_save_vmcoreinfo();
>  			machine_crash_shutdown(&fixed_regs);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/