linux-kernel - RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Nov 2011 11:31:11 +0530
From:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
CC:	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	�ڰ��� <kyungmin.park@...sung.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	"R, Durgadoss" <durgadoss.r@...el.com>
Subject: RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042
 fuel gauge



> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@...il.com]
> Sent: Saturday, November 26, 2011 5:46 AM
> To: Pallala, Ramakrishna
> Cc: myungjoo.ham@...sung.com; linux-kernel@...r.kernel.org; dwmw2@...radead.org; �ڰ���;
> Wolfram Sang; R, Durgadoss
> Subject: Re: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel gauge
> 
> On Wed, Sep 07, 2011 at 02:00:29PM +0530, Pallala, Ramakrishna wrote:
> > > > In max17042_get_property(...), the values returned by
> > > > max17042_read_reg are directly assigned to the variables,
> > > > even if the read results in an error.
> > > >
> > > > This patch checks for the return code from max17042_read_reg and
> > > > exits the function if there is any error.
> > > >
> > > > Signed-off-by: Ramakrishna Pallala
> > > > ---
> > > > drivers/power/max17042_battery.c |   85 ++++++++++++++++++++++++++------------
> > > > 1 files changed, 58 insertions(+), 27 deletions(-)
> > > >
> > >
> > > Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>
> >
> > Thanks for the Ack.
> > When can I expect the patch to be merged ?
> 
> Merged, much thanks!
> 
> Note that I had to manually fix conflicts with
> 
> 	commit cf7a8c03db792894f436db5f3ffc44d947b9b068
> 	Author: MyungJoo Ham <myungjoo.ham@...sung.com>
> 	Date:   Wed Aug 17 10:18:34 2011 +0900
> 
> 	    max17042_battery: Bugfix of incorrect voltage register value interpretation
> 
> 
> So, the resulting patch in battery-2.6.git tree as follows, please
> check if everything is OK:

The patch looks good.
Thanks for resolving the conflicts :)

Thanks,
Ram