linux-kernel - Re: [PATCH 1/1] sched/rt: code cleanup, remove a redundant function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Nov 2011 12:23:15 +0530
From:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:	Shan Hai <haishan.bai@...il.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	tglx@...utronix.de
Subject: Re: [PATCH 1/1] sched/rt: code cleanup, remove a redundant function
 call

* Shan Hai <haishan.bai@...il.com> [2011-11-29 11:03:56]:

> The second time call to sched_rt_period is redundant, because the value of the
> rt_runtime was already read and it was protected by the rurt_runtime_lock.
> 
> Signed-off-by: Shan Hai <haishan.bai@...il.com>

Reviewed-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>

> ---
>  kernel/sched_rt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index 056cbd2..2171ac8 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -645,7 +645,7 @@ static int sched_rt_runtime_exceeded(struct rt_rq *rt_rq)
>  	if (rt_rq->rt_throttled)
>  		return rt_rq_throttled(rt_rq);
> 
> -	if (sched_rt_runtime(rt_rq) >= sched_rt_period(rt_rq))
> +	if (runtime >= sched_rt_period(rt_rq))
>  		return 0;
> 
>  	balance_runtime(rt_rq);
> -- 
> 1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/