linux-kernel - Re: [PATCH] sched: Proper initialization of root_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Nov 2011 12:17:39 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Heechul Yun <heechul@...inois.edu>
Cc:	pjt@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: Proper initialization of root_task_group

On Tue, 2011-11-29 at 23:42 -0600, Heechul Yun wrote:
> Hi,
> 
> The following patch fix a initialization issue.
> 
> Thanks
> 
> Heechul
> 
> ---
> The root_task_group.cfs_bandwidth and root_task_group.shares
> were initialized multiple times unnecessarily which are corrected
> by this patch.

The changelog and you comment above contradict each other. Multiple
initialization isn't a bug, therefore there isn't anything an issue as
such and nothing to 'fix'.

Anyway, the patch adds #ifdeffery, I really rather prefer the double
init over more #ifdeffery.

If you can sort it without introducing more #ifdeffery, or rather, even
reduce the #ifdeffery, I'll take it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/