linux-kernel - Re: [PATCH-RFC 1/2 v2] tile: don't panic on iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 30 Nov 2011 14:23:43 -0500
From:	Chris Metcalf <cmetcalf@...era.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	Arnd Bergmann <arnd@...db.de>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Paul Mundt <lethal@...ux-sh.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	"David S. Miller" <davem@...emloft.net>,
	<linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-arch@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH-RFC 1/2 v2] tile: don't panic on iomap

On 11/30/2011 4:08 AM, Michael S. Tsirkin wrote:
> I think panic on iomap is there just for debugging.
> If we return NULL instead, the generic pci_iomap will
> do the same thing as the custom one that tile currently has
> (that is, return NULL on an IO BAR)
> so tile won't need to roll its own anymore.
>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>
> Note: the other patch in the series is unchanged.
> Changes from v1:
>   - tweaked pr_info message
>
>  arch/tile/include/asm/io.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/tile/include/asm/io.h b/arch/tile/include/asm/io.h
> index c9ea165..d2152de 100644
> --- a/arch/tile/include/asm/io.h
> +++ b/arch/tile/include/asm/io.h
> @@ -204,7 +204,8 @@ static inline long ioport_panic(void)
>  
>  static inline void __iomem *ioport_map(unsigned long port, unsigned int len)
>  {
> -	return (void __iomem *) ioport_panic();
> +	pr_info("ioport_map: mapping IO resources is unsupported on tile.\n");
> +	return NULL;
>  }
>  
>  static inline void ioport_unmap(void __iomem *addr)

Acked-by: Chris Metcalf <cmetcalf@...era.com>

I agree with Arnd that this isn't necessarily the best solution (build-time
failures are always preferable) but given that he's planning some more
ambitious work, this seems reasonable to me.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/