linux-kernel - Re: [PATCH 1/4] staging: vt6656: channel.c: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 1 Dec 2011 18:00:03 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Marcos Paulo de Souza <marcos.mage@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Forest Bond <forest@...ttletooquiet.net>
Subject: Re: [PATCH 1/4] staging: vt6656: channel.c: Remove dead code

On Thu, Dec 01, 2011 at 12:22:49AM +0000, Marcos Paulo de Souza wrote:
> This patch remove some unneeded code. Some comments, for loop doing
> nothing, debug messages and unneeded variables was removed.
> 

This rewrites some stuff, it's not just deleting stuff...  Yes,
you've rewritten it in a better way, but you should mention that in
the changelog.  Maybe break it up into smaller patches or something?

> @@ -463,51 +444,23 @@ void CHvInitChannelTable(void *pDeviceHandler)
>  
>      if ((pDevice->dwDiagRefCount != 0) ||
>          (pDevice->b11hEable == TRUE)) {
> -        if (bMultiBand == TRUE) {
> -		for (ii = 0; ii < CB_MAX_CHANNEL; ii++) {
> +	if (bMultiBand == TRUE)
                                ^
Don't delete the '{' from here.  Multi-line indents get {} braces
even though it's not needed for semantic reasons.

I told you that yesterday.  :/

> +		for (ii = 0; ii < CB_MAX_CHANNEL; ii++)
>  			sChannelTbl[ii+1].bValid = TRUE;

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)