| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Dec 2011 11:17:24 -0800 From: Greg KH <greg@...ah.com> To: Andi Kleen <andi@...stfloor.org> Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, fengguang.wu@...el.com, Andi Kleen <ak@...ux.intel.com> Subject: Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files On Fri, Dec 02, 2011 at 10:43:25AM -0800, Andi Kleen wrote: > From: Andi Kleen <ak@...ux.intel.com> > > Allow passing path names to debugfs_create* and automatically create > the parents. This makes it much simpler for the caller to create hierarchies. > > The way the reference counts are handled is admittedly a bit ugly. > > There is no way to clean them up currently other than to delete the tree, > but that doesn't seem like a big problem for debugfs to leave > behind a few empty directories. I like this, but some documentation will probably need to be added somwhere saying that it's now legal to create a debugfs file with "this/is/a/tree" and have it all be expanded out. And yes, cleaning up the directories shouldn't be a big issue, but what if the directory is already there and it tries to be created again? Shouldn't you do a lookup first and use that dentry if it's there? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists