linux-kernel - Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Dec 2011 21:13:42 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags on
 error

On Tue, Dec 06, 2011 at 08:14:58PM +0100, Ingo Molnar wrote:
> 
> Anyway, SOB flaming aside, i think there's now consensus that we 
> don't want to disable lockdep for TAINT_OOT modules.

OK, glad we could work this out.

> Mind (re-)sending a delta patch against tip:master that excludes 
> that taint flag in addition to the already excluded 
> TAINT_FIRMWARE case? That should close this rather verbose 
> chapter of taint flag handling changes for good ;-)

I originally assumed that lock debugging was being disabled on a
tainted kernel in order to save kernel developers from having to
handle false lockdep errors that are due to external bugs.  The
intent of my proposed change was to achieve this same effect by
showing taint flags instead.  Although the immediate motivation
for this was the new TAINT_OOT_MODULE, I don't see that it is
important for any taint flag to have this disabling effect now.

If you want to ensure that lock debugging is not available to
proprietary modules, I don't have a problem with that, although there
is no legal or practical way for us to stop proprietary module
developers evading this check and doing lock debugging in the privacy
of their offices.

So what I would like to do is either:

1. No longer disable lock debugging due to any taint
or
2. Disable lock debugging only when TAINT_PROPRIETARY_MODULE is set

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/