linux-kernel - Re: CIFS mount: 3.2.0-rc3 suspend crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Dec 2011 22:33:50 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Jeff Layton <jlayton@...hat.com>
Cc:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Woody Suwalski <terraluna977@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PM mailing list <linux-pm@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>,
	Belisko Marek <marek.belisko@...il.com>,
	linux-cifs@...r.kernel.org
Subject: Re: CIFS mount: 3.2.0-rc3 suspend crash

On Wednesday, November 30, 2011, Jeff Layton wrote:
> On Wed, 30 Nov 2011 11:03:59 +0530
> "Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com> wrote:

[...]
> 
> cifs: attempt to freeze while looping on a receive attempt
> 
> In the recent overhaul of the demultiplex thread receive path, we
> neglected to ensure that we attempt to freeze on each pass through the
> loop.
> 
> Reported-by: Woody Suwalski <terraluna977@...il.com>
> Signed-off-by: Jeff Layton <jlayton@...hat.com>

I suppose this patch is going to go through the CIFS tree?

Rafael


> ---
>  fs/cifs/connect.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index bf82f88..d166e3a 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -441,6 +441,8 @@ cifs_readv_from_socket(struct TCP_Server_Info *server, struct kvec *iov_orig,
>  	smb_msg.msg_controllen = 0;
>  
>  	for (total_read = 0; to_read; total_read += length, to_read -= length) {
> +		try_to_freeze();
> +
>  		if (server_unresponsive(server)) {
>  			total_read = -EAGAIN;
>  			break;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/