linux-kernel - RE: [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 07 Dec 2011 15:57:07 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Thomas Meyer' <thomas@...3r.de>, ben-linux@...ff.org,
	linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: RE: [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating its
 implementation

Thomas Meyer wrote:
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/memdup.cocci.
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
> 
> diff -u -p a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> --- a/arch/arm/plat-s3c24xx/dma.c 2011-11-07 19:37:20.736205210 +0100
> +++ b/arch/arm/plat-s3c24xx/dma.c 2011-11-08 11:03:41.719762852 +0100
> @@ -1437,11 +1437,10 @@ int __init s3c24xx_dma_init_map(struct s
>  	size_t map_sz = sizeof(*nmap) * sel->map_size;
>  	int ptr;
> 
> -	nmap = kmalloc(map_sz, GFP_KERNEL);
> +	nmap = kmemdup(sel->map, map_sz, GFP_KERNEL);
>  	if (nmap == NULL)
>  		return -ENOMEM;
> 
> -	memcpy(nmap, sel->map, map_sz);
>  	memcpy(&dma_sel, sel, sizeof(*sel));
> 
>  	dma_sel.map = nmap;

Yes, looks ok to me, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/