linux-kernel - Re: [git pull] apparmor fix for __d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Dec 2011 16:42:00 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	John Johansen <john.johansen@...onical.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] apparmor fix for __d_path() misuse

On Tue, Dec 6, 2011 at 4:39 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> IOW, I mean this:

Yeah, no.

> +       if (ancestor) {
> +               ancestor->mnt = mntget(vfsmnt);
> +               ancestor->dentry = dget(dentry);
> +       }

This part is still just pure and utter sh*t.

You have not explained why that information is *ever* valid. And I
claim it isn't.

We have a bug in our current __d_path(). And I claim that the
underlying cause of the bug is the crazy "let's return this
nonsensical and idiotic information that cannot possibly make sense to
anybody".

We shouldn't have done that in the first place. And we certainly
shouldn't *continue* doing that.

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/