linux-kernel - [tip:core/locking] lockdep, bug: Exclude TAINT_OOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Dec 2011 20:37:11 -0800
From:	tip-bot for Ben Hutchings <ben@...adent.org.uk>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	debian-kernel@...ts.debian.org, nbowler@...iptictech.com,
	hpa@...or.com, mingo@...hat.com, rusty@...tcorp.com.au,
	peterz@...radead.org, greg@...ah.com, rdunlap@...otime.net,
	davej@...hat.com, ben@...adent.org.uk, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:core/locking] lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging

Commit-ID:  9ec84acee1e221d99dc33237bff5e82839d10cc0
Gitweb:     http://git.kernel.org/tip/9ec84acee1e221d99dc33237bff5e82839d10cc0
Author:     Ben Hutchings <ben@...adent.org.uk>
AuthorDate: Wed, 7 Dec 2011 14:30:58 +0000
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Wed, 7 Dec 2011 23:32:10 +0100

lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging

We do want to allow lock debugging for GPL-compatible modules
that are not (yet) built in-tree.  This was disabled as a
side-effect of commit 2449b8ba0745327c5fa49a8d9acffe03b2eded69
('module,bug: Add TAINT_OOT_MODULE flag for modules not built
in-tree').  Lock debug warnings now include taint flags, so
kernel developers should still be able to deflect warnings
caused by out-of-tree modules.

The TAINT_PROPRIETARY_MODULE flag for non-GPL-compatible modules
will still disable lock debugging.

Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
Cc: Nick Bowler <nbowler@...iptictech.com>
Cc: Greg KH <greg@...ah.com>
Cc: Dave Jones <davej@...hat.com>
Cc: Rusty Russell <rusty@...tcorp.com.au>
Cc: Randy Dunlap <rdunlap@...otime.net>
Cc: Debian kernel maintainers <debian-kernel@...ts.debian.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Alan Cox <alan@...ux.intel.com>
Link: http://lkml.kernel.org/r/1323268258.18450.11.camel@deadeye
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 kernel/panic.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 1b83fd8..3458469 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -237,11 +237,12 @@ void add_taint(unsigned flag)
 	 * Can't trust the integrity of the kernel anymore.
 	 * We don't call directly debug_locks_off() because the issue
 	 * is not necessarily serious enough to set oops_in_progress to 1
-	 * Also we want to keep up lockdep for staging development and
-	 * post-warning case.
+	 * Also we want to keep up lockdep for staging/out-of-tree
+	 * development and post-warning case.
 	 */
 	switch (flag) {
 	case TAINT_CRAP:
+	case TAINT_OOT_MODULE:
 	case TAINT_WARN:
 	case TAINT_FIRMWARE_WORKAROUND:
 		break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/