linux-kernel - Re: [PATCH] Input: bcm5974

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 10:02:52 +0100
From:	Oliver Neukum <oneukum@...e.de>
To:	"Henrik Rydberg" <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>
Subject: Re: [PATCH] Input: bcm5974 - Fix USB autosuspend

Am Montag, 12. Dezember 2011, 10:06:04 schrieb Henrik Rydberg:
> @@ -895,6 +857,10 @@ static int bcm5974_probe(struct usb_interface *iface,
>         /* save our data pointer in this interface device */
>         usb_set_intfdata(iface, dev);
>  
> +       error = bcm5974_start_traffic(dev);
> +       if (error)
> +               goto err_free_buffer;
> +
>         return 0;
>  
>  err_free_buffer:
> -- 

Why do you want to start traffic before open() in probe() ?
It doesn't make sense to ask a device to deliver data nobody
wants.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/