linux-kernel - Re: [PATCH -next] proc: fix task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 15:31:56 +0400
From:	Vasiliy Kulikov <segoon@...nwall.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org,
	Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH -next] proc: fix task_struct infoleak

On Sun, Dec 11, 2011 at 20:59 +0000, Al Viro wrote:
> On Sun, Dec 11, 2011 at 10:28:21PM +0400, Vasiliy Kulikov wrote:
> > proc_pid_permission() doesn't put task_struct on every /proc/$pid/
> > access.  A demo from Hugh Dickins:
> > 
> > while :; do ps; grep KernelStack /proc/meminfo; sleep 1; done
> > 
> > Reported-by: Hugh Dickins <hughd@...gle.com>
> > Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>
> > ---
> >  This is a patch against a hidepid patchset from -mm.
> 
> Choose saner commit summary, please.  It's not information leak, for pity sake
> - it's a plain and simple memory leak...

Oops!  s/infoleak/memleak/ surely, bad habit...

Thank you, I'll resend the patch.


-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/