linux-kernel - Re: [PATCH v6 10/10] arm/tegra: add support for tegra30 based board cardhu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Dec 2011 16:26:16 -0800
From:	Olof Johansson <olof@...om.net>
To:	Rob Herring <robherring2@...il.com>
Cc:	Peter De Schrijver <pdeschrijver@...dia.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Randy Dunlap <rdunlap@...otime.net>,
	Russell King <linux@....linux.org.uk>,
	Colin Cross <ccross@...roid.com>,
	Stephen Warren <swarren@...dia.com>,
	Gary King <gking@...dia.com>,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH v6 10/10] arm/tegra: add support for tegra30 based board
 cardhu

On Fri, Dec 09, 2011 at 08:29:59AM -0600, Rob Herring wrote:
> On 12/08/2011 06:43 AM, Peter De Schrijver wrote:
> > Add support for the tegra30 based cardhu development board. Cardhu is a tablet
> > formfactor reference design for tegra30. The patch provides a device tree for
> > the board, updates Makefile.boot to build the dtb, includes the platform in
> > Kconfig and updates board-dt.c.
> > 
> > Signed-off-by: Peter De Schrijver <pdeschrijver@...dia.com>
> > ---
> >  arch/arm/boot/dts/tegra-cardhu.dts |   36 ++++++++++++++++++++++++++++++++++++
> >  arch/arm/mach-tegra/Kconfig        |    7 +++++++
> >  arch/arm/mach-tegra/Makefile.boot  |    1 +
> >  arch/arm/mach-tegra/board-dt.c     |    1 +
> >  4 files changed, 45 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/boot/dts/tegra-cardhu.dts
> > 
> > diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts
> > new file mode 100644
> > index 0000000..70c41fc
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/tegra-cardhu.dts
> > @@ -0,0 +1,36 @@
> > +/dts-v1/;
> > +
> > +/include/ "tegra30.dtsi"
> > +
> > +/ {
> > +	model = "NVIDIA Tegra30 Cardhu evaluation board";
> > +	compatible = "nvidia,cardhu", "nvidia,tegra30";
> > +
> > +	memory {
> 
> memory@...00000

If there is only one memory node, then there is no need to specify the unit
address after the name, it's just noise.

> > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> > index aad54ca..6bae1bb 100644
> > --- a/arch/arm/mach-tegra/Kconfig
> > +++ b/arch/arm/mach-tegra/Kconfig
> > @@ -91,6 +91,13 @@ config MACH_VENTANA
> >         help
> >           Support for the nVidia Ventana development platform
> >  
> > +config MACH_CARDHU
> > +       bool "Cardhu board"
> > +       depends on ARCH_TEGRA_3x_SOC
> > +       select MACH_TEGRA_DT
> > +       help
> > +         Support for the NVIDIA Cardhu development platform
> > +
> 
> You should not be adding kconfig entries for boards. They should
> eventually go away with DT.

Agreed. On Tegra2 we still want board configs since it allows us to leave out
some of the kernel code that is still per-board (i.e. pinmux tables, etc). Once
that has been moved to device tree we can remove all board kconfig options
there. We might as well not start adding them on T30.

> >  choice
> >          prompt "Low-level debug console UART"
> >          default TEGRA_DEBUG_UART_NONE
> > diff --git a/arch/arm/mach-tegra/Makefile.boot b/arch/arm/mach-tegra/Makefile.boot
> > index cf51a00..7c1110f 100644
> > --- a/arch/arm/mach-tegra/Makefile.boot
> > +++ b/arch/arm/mach-tegra/Makefile.boot
> > @@ -7,3 +7,4 @@ dtb-$(CONFIG_MACH_PAZ00) += tegra-paz00.dtb
> >  dtb-$(CONFIG_MACH_SEABOARD) += tegra-seaboard.dtb
> >  dtb-$(CONFIG_MACH_TRIMSLICE) += tegra-trimslice.dtb
> >  dtb-$(CONFIG_MACH_VENTANA) += tegra-ventana.dtb
> > +dtb-$(CONFIG_MACH_CARDHU) += tegra-cardhu.dtb
> 
> Likewise, this should be more like:
> dtb-$(CONFIG_MACH_TEGRA_DT) += tegra-seaboard.dtb tegra-trimslice.dtb
> tegra-ventana.dtb ...

Actually, the cardhu dts CONFIG_ARCH_TEGRA_3x_SOC, since there will only be DT
boards for that platform.

Moving the others to TEGRA_DT is a later change (see above comments about some
C code still needed).


-Olof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/