linux-kernel - Re: [PATCH 0/5] x86, microcode, AMD: Size checking fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 18:34:31 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Borislav Petkov <bp@...64.org>
Cc:	X86-ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH 0/5] x86, microcode, AMD: Size checking fixes


* Borislav Petkov <bp@...64.org> wrote:

> From: Borislav Petkov <borislav.petkov@....com>
> 
> Hi all,
> 
> this is a patchset that reworks and fixes ucode size checking. 
> The meat of it is contained in 3/5 which reworks the code to 
> iterate over the patches in the microcode binary image 
> _without_ vmalloc-ing space for every patch in succession in 
> order to look at it and go on to the next, if it doesn't fit.
> 
> In any case, we end up loading at most one patch so before we 
> copy it in local storage we do all possible checks on it now, 
> and copy it only then, if all checks are passed.
> 
> Also, for simplicity, we alloc a single 4K page as a buffer 
> for it which we keep per CPU as long as the ucode module is 
> loaded and free upon exit. This simplifies all 
> allocations/cleanup paths significantly.

No objections from anyone it appears - did you want to send this 
as a pull request?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/