linux-kernel - RE: [PATCH 2/2] trace,x86: Add x86 irq vector entry/exit tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 16:52:18 -0500
From:	Seiji Aguchi <seiji.aguchi@....com>
To:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Steven Rostedt <rostedt@...dmis.org>
CC:	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	Satoru Moriya <satoru.moriya@....com>
Subject: RE: [PATCH 2/2] trace,x86: Add x86 irq vector entry/exit tracepoints

Hi,

I'm interested in these tracepoints.
But this patch removed from -mm tree for some reason.

http://www.spinics.net/lists/mm-commits/msg85707.html

Do you plan to update it and push to upstream?

>@@ -859,7 +860,9 @@ void __irq_entry smp_apic_timer_interrupt(struct pt_regs *regs)
> 	 */
> 	exit_idle();
> 	irq_enter();
>+	trace_irq_vector_entry(LOCAL_TIMER_VECTOR);
> 	local_apic_timer_interrupt();
>+	trace_irq_vector_exit(LOCAL_TIMER_VECTOR);
> 	irq_exit();

It would be better if you add "regs" to the argument of trace_irq_vector_entry()/ trace_irq_vector_exit().

With "regs", we are able to know what part of the system CPUs execute periodically. 
This information really helps us find a root cause of system slowdown or hung up.

Seiji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/