linux-kernel - Re: [PATCH] backlight: ep93xx_bl: remove duplicated header include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Dec 2011 09:11:27 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Andrew Morton' <akpm@...ux-foundation.org>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Richard Purdie' <rpurdie@...ys.net>,
	'H Hartley Sweeten' <hsweeten@...ionengravers.com>
Subject: Re: [PATCH] backlight: ep93xx_bl: remove duplicated header include

On 12/12/11 18:51, Jingoo Han wrote:

> This patch removes duplicated module header for EP93xx backlight
> driver.
> drivers/video/backlight/ep93xx_bl.c: module.h is included more
> than once.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/video/backlight/ep93xx_bl.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index c74a6f4..4893dff 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -10,10 +10,8 @@
>   * This driver controls the pulse width modulated brightness control output,
>   * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
>   */
> -


Please don't remove the blank line between the header comment and the
first include.

~Ryan

>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> -#include <linux/module.h>
>  #include <linux/io.h>
>  #include <linux/fb.h>
>  #include <linux/backlight.h>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/