linux-kernel - Re: [PATCH] staging: wlan-ng: prism: coding style fixes, removed space-indentations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 13 Dec 2011 19:50:34 +0100
From:	Dan Luedtke <mail@...rl.de>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: prism: coding style fixes, removed
 space-indentations

Hello,

On Tue, Dec 13, 2011 at 7:27 PM, Dan Carpenter
<dan.carpenter@...cle.com> wrote:
> Everyone's first patch is rejected, so don't feel bad.  :)  Btw put
> these kind of comments which you don't want in the permanent git log
> under the --- dashes.  git am removes that information.
Thanks for the feedback!  I'm glad I managed git send-email without
breaking up something, so no offense taken that the patch got rejected.

> It looks like you've tried to make everything aligned with the right
> hand side of the screen.  I think that's the first time I've seen
> someone do that.  I don't think it's normal.
Thank god! I am working on a kmodule, and the code looks awful that way.
I think I have to dig deeper into CodingStyle.txt

>> -----------------------------------------------------------------*/
>> +*----------------------------------------------------------------*/
>
> There is a normal kernel comment style described in Chapter 8 of
> Documentation/CodingStyle.
Now I am confused, as I understand multi-line comments should start
every line but the first with a *.
Anyway, one should commit code before bothering about comments, so I
silence myself here.

> Documentation/kernel-doc-nano-HOWTO.txt
Printed.

Again, thanks for the feedback! Will work on that and come back later
when I found something in the kernel to work on or when my module leaves
design-phase.

regards,
Dan

-- 
Dan Luedtke
http://www.danrl.de

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/