linux-kernel - Re: [PATCH RESEND 1/2] MFD: MAX8997: add platform data and devices for LED control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Dec 2011 21:59:05 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Donggeun Kim <dg77.kim@...sung.com>
Cc:	linux-kernel@...r.kernel.org, rpurdie@...ys.net,
	broonie@...nsource.wolfsonmicro.com, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com
Subject: Re: [PATCH RESEND 1/2] MFD: MAX8997: add platform data and devices
 for LED control

Hi Donggeun,

On Tue, Dec 13, 2011 at 05:13:52PM +0900, Donggeun Kim wrote:
> diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
> index 5be53ae..cb83a7a 100644
> --- a/drivers/mfd/max8997.c
> +++ b/drivers/mfd/max8997.c
> @@ -43,7 +43,8 @@ static struct mfd_cell max8997_devs[] = {
>  	{ .name = "max8997-battery", },
>  	{ .name = "max8997-haptic", },
>  	{ .name = "max8997-muic", },
> -	{ .name = "max8997-flash", },
That doesn't seem to be related to this patch.


> +	{ .name = "max8997-led", .id = 1 },
> +	{ .name = "max8997-led", .id = 2 },
>  };
> @@ -172,7 +194,8 @@ struct max8997_platform_data {
>  
>  	/* HAPTIC: Not implemented */
>  	/* RTC: Not implemented */
> -	/* Flash: Not implemented */
> +	/* ---- Flash ---- */
> +	struct max8997_led_platform_data *led_pdata;
This is a bit confusing: Flash and LED ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/