linux-kernel - Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Dec 2011 00:03:03 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andi Kleen <ak@...ux.intel.com>
cc:	Cyrill Gorcunov <gorcunov@...il.com>,
	Andi Kleen <andi@...stfloor.org>, greg@...ah.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs
 files v2

On Tue, 13 Dec 2011, Andi Kleen wrote:

> > Hi Andi, is it possible to do say kstrdup or something instead of
> 
> It's possible, just would add complexity with an additional
> error path.
> 
> > variable-size array in fn[strlen(name) + 1] ? As far as I remember
> > we already had some warnings with them at least in perf land (or
> > trace land). Or I miss something?
> 
> Not aware of any problems with tracing or perf. I like them at least.

That does not make them better. We had wreckage before and you can
just consult commit a84a79e4d3 and then find a good explanation why
your usage is safe.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/