linux-kernel - Re: [PATCH] arch/tile: misplaced parens near likely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Dec 2011 11:36:26 -0500
From:	Chris Metcalf <cmetcalf@...era.com>
To:	roel <roel.kluin@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/tile: misplaced parens near likely

On 12/12/2011 5:34 PM, roel wrote:
> Parentheses were missing.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Thanks, I'll take this into the tile tree.

> ---
>  arch/tile/lib/spinlock_32.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> This is what it should be, right?
>
> diff --git a/arch/tile/lib/spinlock_32.c b/arch/tile/lib/spinlock_32.c
> index cb0999f..b16ac49 100644
> --- a/arch/tile/lib/spinlock_32.c
> +++ b/arch/tile/lib/spinlock_32.c
> @@ -144,7 +144,7 @@ void arch_read_unlock(arch_rwlock_t *rwlock)
>  	for (;;) {
>  		__insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 1);
>  		val = __insn_tns((int *)&rwlock->lock);
> -		if (likely(val & 1) == 0) {
> +		if (likely((val & 1) == 0)) {
>  			rwlock->lock = val - (1 << _RD_COUNT_SHIFT);
>  			__insn_mtspr(SPR_INTERRUPT_CRITICAL_SECTION, 0);
>  			break;

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/