linux-kernel - Re: [PATCH 01/29] Staging: comedi: fix printk issue in dt3000.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Dec 2011 12:35:38 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Ravishankar karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
CC:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/29] Staging: comedi: fix printk issue in dt3000.c

On 12/12/11 16:19, Ravishankar karkala Mallikarjunayya wrote:

> This is a patch to the dt3000.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
> 
> Converted printks to dev_<levels>.
> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@...enturtles.in>


There are still numerous issues with these patches, some which have been
pointed out to you several times now and still exist:

 - You are using printk/pr_info, etc where dev_info, etc should be used
 - You are converting some KERN_CONT to multiline dev_info, and in doing
so are now printing useless strings.
 - Some of the printk's you are 'fixing' should just get removed. Don't
blindly replace things, it just creates churn.
 - You are converting some printks to dev_dbg and leaving dev->minor in
the string which is no longer needed.
 - There are some subtle format changes introduced by the printk
changes. Not a big deal, but it should be noted in the changelog. It
might affect some userspace tools for the comedi drivers?
 - You have multiple patches which do the same thing. Why are there two
patches for converting printk -> dev_dbg in das1800.c for example? Why
not do all of the conversion changes for one file in a single patch?
 - Some of your patches don't do what they say they do.
 - You have compile errors still.

Some these patches probably are worth applying, but they are just lost
in the noise.

~Ryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/