linux-kernel - Re: [PATCH] irq: fix crash due to op-less irq domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Dec 2011 23:24:59 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Rob Herring <robherring2@...il.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Jamie Iles <jamie@...ieiles.com>,
	Marc Zyngier <marc.zyngier@....com>,
	Russell King - ARM Linux <linux@....linux.org.uk>
Subject: Re: [PATCH] irq: fix crash due to op-less irq domains

On Wed, Dec 14, 2011 at 11:14 PM, Rob Herring <robherring2@...il.com> wrote:
> Linus,
>
> On 12/14/2011 02:55 PM, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij@...aro.org>
>>
>> IRQ domains without ops does not work anymore after commit
>> "irq: support domains with non-zero hwirq base", since the
>> check dereferences domain->ops->to_irq without checking of
>> domain->ops are NULL. This makes U300 (and probably most other
>> systems using the PL190 VIC) boot again.
>
> I thought the VIC series had the fix for this, but it seems not. NULL
> ops is considered invalid based on the code comments. The correct fix is
> this patch:
>
> irqdomain: export irq_domain_simple_ops for !CONFIG_OF
> http://www.spinics.net/lists/arm-kernel/msg150290.html
>
> I believe this is going in with some iMX changes.

Can we please move this patch over to whatever branch the patch that
breaks my system is on, so I can create a proper fix for the
non-devicetree VIC users then?

Or apply an exact copy of the patch. Git will cope.

(Among the systems broken are likely the ARM Versatile too BTW,
not just obscure things like my U300.)

> But I guess the VIC is
> going to need a fix to use irq_domain_simple_ops.

If I just have the baseline in linux-next, I can fix it, but then I need
that patch in linux-next first, now all non-devicetree VIC systems are
just broken with no way for me to fix them :-(

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/