linux-kernel - RE: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Dec 2011 10:40:44 +0000
From:	Dong Aisheng-B29396 <B29396@...escale.com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	"linus.walleij@...ricsson.com" <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	Guo Shawn-R65073 <r65073@...escale.com>
Subject: RE: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux subsystem

> -----Original Message-----
> From: Sascha Hauer [mailto:s.hauer@...gutronix.de]
> Sent: Thursday, December 15, 2011 5:32 PM
> To: Dong Aisheng-B29396
> Cc: Linus Walleij; linus.walleij@...ricsson.com; linux-
> kernel@...r.kernel.org; rob.herring@...xeda.com;
> grant.likely@...retlab.ca; linux-arm-kernel@...ts.infradead.org;
> kernel@...gutronix.de; Guo Shawn-R65073
> Subject: Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux
> subsystem
> Importance: High
> 
> On Thu, Dec 15, 2011 at 07:23:42AM +0000, Dong Aisheng-B29396 wrote:
> > > -----Original Message-----
> > > From: Linus Walleij [mailto:linus.walleij@...aro.org]
> > > Sent: Thursday, December 15, 2011 6:16 AM
> > > To: Sascha Hauer
> > > Cc: Dong Aisheng-B29396; linus.walleij@...ricsson.com; linux-
> > > kernel@...r.kernel.org; rob.herring@...xeda.com;
> > > grant.likely@...retlab.ca; linux-arm-kernel@...ts.infradead.org;
> > > kernel@...gutronix.de; Guo Shawn-R65073
> > > Subject: Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux
> > > subsystem
> > > Importance: High
> > >
> > > On Wed, Dec 14, 2011 at 10:11 PM, Sascha Hauer
> > > <s.hauer@...gutronix.de>
> > > wrote:
> > > > On Thu, Dec 15, 2011 at 12:03:42AM +0800, Dong Aisheng wrote:
> > >
> > > >> +     pmx = pinmux_get(&pdev->dev, NULL);
> > > >> +     if (IS_ERR(pmx)) {
> > > >> +             err = PTR_ERR(pmx);
> > > >> +             goto err_pmx_get;
> > > >> +     }
> > > >> +     err = pinmux_enable(pmx);
> > > >> +     if (err)
> > > >> +             goto err_pmx_enable;
> > > >> +     imx_data->pmx = pmx;
> > > >> +
> > > >
> > > > Won't this break every i.MX except i.MX6?
> > >
> >
> > If not select PINCTRL, pinmux_enable returns ok by default and
> > pinmux_get Returns NULL which also does not block.
> > So it will not break other i.MX currently since only mx6q are using
> PINCTRL.
> >
> > > Not this patch on its own, first the machines have to select PINCTRL
> > > select PINMUX_FOO
> > >
> > > *Then* it will break :-D
> > >
> >
> > After we move to one single image for mx5 and mx6, it could be an
> > issue Since PINCTRL may be selected by default.
> > So mx5 pinmux driver is in my TODO list.
> 
> Add i.MX3 which is compiled together with i.MX6 :)
> 
Sure, would like to do it.
Thanks

Regards
Dong Aisheng



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/