linux-kernel - Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Dec 2011 15:34:01 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	myungjoo.ham@...sung.com
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	김동근 <dg77.kim@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"broonie@...nsource.wolfsonmicro.com" 
	<broonie@...nsource.wolfsonmicro.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	박경민 <kyungmin.park@...sung.com>
Subject: Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC

On Thursday 15 December 2011, MyungJoo Ham wrote:
> Arnd Bergmann wrote:
> > On Monday 12 December 2011, Samuel Ortiz wrote:
> > The part that is not clear to me is how this new driver fits in
> > with the first fsa9480 driver and the currently discussed extcon
> > subsystem, apparently all written by the same team at Samsung.
> > Is this misc driver still useful when the extcon framework gets
> > merged?
> 
> When extcom gets merged, this driver should be updated. It looks like allowing
> the interrupt handler to update extcon state would be enough. Bascially, this
> is all this driver is required for extcon to work. (and the prvious author of
> extcon--"extended" switch class at that time--was the author of this patch.)
> 
> Anyway, this patch has just told me that I'll need to add more sysfs entries
> for extcon to show the list of cable names and/or to show the status for each
> of them, soon or later.

I think it would be better not to merge this driver until the user interface
in the extcon framework has been finalized. I don't mind the driver, but I
want to prevent user interfaces from appearing in the kernel that we
intend to change anyway.

How about dropping the driver from the mfd tree, and adding it into the
extcon series for the next posting?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/