linux-kernel - linux-next 20111214 - lib/Kconfig help text issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 14 Dec 2011 21:17:14 -0500
From:	Valdis.Kletnieks@...edu
To:	Dmitry Kasatkin <dmitry.kasatkin@...el.com>
Cc:	linux-kernel@...r.kernel.org
Subject: linux-next 20111214 - lib/Kconfig help text issue

Seen in linux-next commit 7e8dec91 ( crypto: GnuPG based MPI lib - additional sources (part 4))

> diff --git a/lib/Kconfig b/lib/Kconfig
> index 4af07ec..d411de5 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -283,4 +283,14 @@ config MPILIB
>           It is used to implement RSA digital signature verification,
>           which is used by IMA/EVM digital signature extension.
>
> +config MPILIB_EXTRA
> +       bool "Multiprecision maths library - additional sources"
> +       depends on MPILIB
> +       help
> +         Multiprecision maths library from GnuPG.
> +         It is used to implement RSA digital signature verification,
> +         which is used by IMA/EVM digital signature extension.
> +         This code in unnecessary for RSA digital signature verification,
> +         and can be compiled if needed.
> +

Two issues:

1) Typo - "this code in unnecessary" should be "this code is"

2) The help file says "It is used to implement verification", and then 2 lines
later it says "this code is unnesessary for verification".  So is it implementing
it, or not needed for it?  (I suspect it's a bad cut-n-paste from the
previous section, and needs 2 lines deleted, to look like this:

+       help
+         Multiprecision maths library from GnuPG.
+         This code in unnecessary for RSA digital signature verification,
+         and can be compiled if needed.




Content of type "application/pgp-signature" skipped