linux-kernel - Re: [GIT PULL] ibft fix for 3.2-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Dec 2011 15:15:55 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Konrad Rzeszutek Wilk <konrad@...nok.org>, Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, pjones@...hat.com,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Len Brown <lenb@...nel.org>
Subject: Re: [GIT PULL] ibft fix for 3.2-rc6

On Thu, Dec 15, 2011 at 1:05 PM, Konrad Rzeszutek Wilk
<konrad@...nok.org> wrote:
> Hey Linus,
>
> Please git pull the following branch:
>
>  git pull git://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git linux-next
>
> which has a fix to make the ACPI table called 'iSCSI Boot Format Table'
> (IBFT) be found by the iscsi-ibft driver when booting under UEFI.
>
> The functionality to grab the APCI IBFT was added some time ago, but we
> did not have the UEFI box to test it. Now that it has been tested it was
> uncovered that the ACPI parser code was run way to early - so it did not
> parse the iBFT table at all. This patch fixes it by doing the ACPI parsing later.
> The legacy iBFT searching is not affected (which is to scan 640K->1MB
> for the iBFT signature) and works correctly.
>
> Please pull!
>
> Yinghai Lu (1):
>      ibft: Fix finding IBFT ACPI table on UEFI
>
>  drivers/firmware/iscsi_ibft.c      |   42 ++++++++++++++++++++++++++++++++++-
>  drivers/firmware/iscsi_ibft_find.c |   26 +--------------------
>  2 files changed, 42 insertions(+), 26 deletions(-)

Greg,

Can you please put this one into stable

	935a9fee51c945b8942be2d7b4bae069167b4886

actually,  even still need to apply to 2.6.32 stable

but commit description could be some different:

for 2.6.32, and kernel before memblock is supported in x86:
Even we call reserve_ibft_region() in x86 setup_arch() some late, but
it still in early stage.
at that time, acpi table is mapped for temporal use and will be
unmapped after handler is called
So handler should not store remapped address for late use.

only after init_main()/early_acpi_init(), we can store those remapped
address for acpi tables in handles

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/