linux-kernel - Re: [PATCH 1/4] ACPI: EC: Add ec_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Dec 2011 00:33:33 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Thomas Renninger <trenn@...e.de>
Cc:	Seth Forshee <seth.forshee@...onical.com>,
	Len Brown <lenb@...nel.org>,
	Azael Avalos <coproscefalo@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Henrique de Moraes Holschuh <hmh@....eng.br>
Subject: Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote:

> I think best is to move the thinkpad implementation of getting
> ACPI handles based on HIDs to osl.c and make it global.
> I'll send patches.
> Please review them carefully, they are only compile tested.

The ec driver is already finding the hardware on the basis of the HID - 
is there any reason to do this twice rather than just exporting the 
information the ec driver already has?

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/