linux-kernel - Re: [PATCH] cgroups: fix a css_set not found bug in cgroup_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Dec 2011 10:12:51 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Mandeep Singh Baines <msb@...omium.org>,
	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org,
	stable@...nel.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Menage <paul@...lmenage.org>,
	Olof Johansson <olofj@...omium.org>
Subject: Re: [PATCH] cgroups: fix a css_set not found bug in cgroup_attach_proc

Tejun Heo wrote:
> On Thu, Dec 15, 2011 at 11:36:43AM -0800, Mandeep Singh Baines wrote:
>> There is a BUG when migrating a PF_EXITING proc. Since css_set_prefetch()
>> is not called for the PF_EXITING case, find_existing_css_set() will return
>> NULL inside cgroup_task_migrate() causing a BUG.
>>
>> This bug is easy to reproduce. Create a zombie and echo its pid to
>> cgroup.procs.
>>
>> $ cat zombie.c
>> \#include <unistd.h>
>>
>> int main()
>> {
>>   if (fork())
>>       pause();
>>   return 0;
>> }
>> $
>>
>> We are hitting this bug pretty regularly on ChromeOS.
>>
>> This bug is already fixed by Tejun Heo's cgroup patchset which is
>> targetted for the next merge window:
>>
>> https://lkml.org/lkml/2011/11/1/356
>>
>> I've create a smaller patch here which just fixes this bug so that a
>> fix can be merged into the current release and stable.
> 
> Looks safe to me.  Li?
> 

It should be fine.

Reviewed-by: Li Zefan <lizf@...fujitsu.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/