linux-kernel - Re: linux-next: build failure after merge of the final tree (akpm tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 17 Dec 2011 16:02:28 +1100
From:	NeilBrown <neilb@...e.de>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Richard Purdie <rpurdie@...ys.net>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: linux-next: build failure after merge of the final tree (akpm
 tree related)

On Sat, 17 Dec 2011 15:42:19 +1100 Stephen Rothwell <sfr@...b.auug.org.au>
wrote:

> Hi all,
> 
> After merging the final tree, today's linux-next build (m68k allmodconfig)
> failed like this:
> 
> drivers/leds/leds-tca6507.c:158: error: field 'gpio' has incomplete type
> drivers/leds/leds-tca6507.c: In function 'tca6507_gpio_set_value':
> drivers/leds/leds-tca6507.c:534: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/leds/leds-tca6507.c:534: warning: initialization from incompatible pointer type
> drivers/leds/leds-tca6507.c: In function 'tca6507_probe':
> drivers/leds/leds-tca6507.c:618: error: implicit declaration of function 'gpiochip_add'
> drivers/leds/leds-tca6507.c: In function 'tca6507_remove':
> drivers/leds/leds-tca6507.c:651: error: implicit declaration of function 'gpiochip_remove'
> 
> Caused by commit 7a9244d89523 ("leds: add driver for TCA6507 LED controller").
> 
> Maybe this driver needs some dependencies ...

Yes... I think it actually needs the 'gpio' aspect of the driver to be
dependant of GPIOLIB being available.

I'll get a patch or two off to Andrew on Monday.

Thanks,
NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)