linux-kernel - [PATCH RESEND 1/3] mfd: Fix checking bit_mask for adp5520_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Dec 2011 19:55:57 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Michael Hennerich <hennerich@...ckfin.uclinux.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	device-drivers-devel@...ckfin.uclinux.org
Subject: [PATCH RESEND 1/3] mfd: Fix checking bit_mask for adp5520_set_bits

Current code checks if all the bit_mask bits are all zero is wrong.
We need to write new value if old value is not equal to new value.

Signed-off-by: Axel Lin <axel.lin@...il.com>
Acked-by: Michael Hennerich <michael.hennerich@...log.com>
---
Hi Samuel,
I found this serial of patches are not merged yet. 
( although you replied that you applied all 3 patches in the mail )
It was post on https://lkml.org/lkml/2011/10/30/137
So I resend it again.

Thanks,
Axel
 drivers/mfd/adp5520.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
index f1d8848..8d816cc 100644
--- a/drivers/mfd/adp5520.c
+++ b/drivers/mfd/adp5520.c
@@ -109,7 +109,7 @@ int adp5520_set_bits(struct device *dev, int reg, uint8_t bit_mask)
 
 	ret = __adp5520_read(chip->client, reg, &reg_val);
 
-	if (!ret && ((reg_val & bit_mask) == 0)) {
+	if (!ret && ((reg_val & bit_mask) != bit_mask)) {
 		reg_val |= bit_mask;
 		ret = __adp5520_write(chip->client, reg, reg_val);
 	}
-- 
1.7.5.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/