linux-kernel - Re: [PATCH 9/9] usb: gadget: goku: use generic map/unmap routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Dec 2011 15:09:47 +0200
From:	Felipe Balbi <balbi@...com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	Felipe Balbi <balbi@...com>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	"Greg Kroah-Hartman (supporter:USB SUBSYSTEM ,commit_signer:28/50=56%)" 
	<gregkh@...e.de>,
	"Thomas Dahlmann (supporter:AMD GEODE CS5536...)" 
	<dahlmann.thomas@...or.de>,
	"Kuninori Morimoto (commit_signer:43/50=86%)" 
	<kuninori.morimoto.gx@...esas.com>,
	"open list:DESIGNWARE USB3 D..." <linux-omap@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:AMD GEODE CS5536..." <linux-geode@...ts.infradead.org>
Subject: Re: [PATCH 9/9] usb: gadget: goku: use generic map/unmap routines

On Mon, Dec 19, 2011 at 05:02:51PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 19-12-2011 14:30, Felipe Balbi wrote:
> 
> >those routines have everything we need to map/unmap
> >USB requests and it's better to use them.
> 
> >Signed-off-by: Felipe Balbi<balbi@...com>
> >---
> >  drivers/usb/gadget/goku_udc.c |   17 +++++++----------
> >  1 files changed, 7 insertions(+), 10 deletions(-)
> 
> >diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c
> >index 5af70fcc..bc47735 100644
> >--- a/drivers/usb/gadget/goku_udc.c
> >+++ b/drivers/usb/gadget/goku_udc.c
> [...]
> >@@ -736,10 +732,11 @@ goku_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
> >  		return -EBUSY;
> >
> >  	/* set up dma mapping in case the caller didn't */
> >-	if (ep->dma&&  _req->dma == DMA_ADDR_INVALID) {
> >-		_req->dma = pci_map_single(dev->pdev, _req->buf, _req->length,
> >-			ep->is_in ? PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE);
> >-		req->mapped = 1;
> >+	if (ep->dma) {
> >+		status = usb_gadget_map_request(&dev->gadget, &req->req,
> 
>    Not '&_req->req'?

of course not. _req is the usb_request not Goku's internal
representation. I could change that to:

	usb_gadget_map_request(&dev->gadget, _req, ep->is_in);

though.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)