linux-kernel - Re: [PATCH 1/3] usb: musb: fix pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Dec 2011 22:21:53 +0200
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH 1/3] usb: musb: fix pm_runtime mismatches

On Fri, Dec 16, 2011 at 5:30 AM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Fri, 16 Dec 2011, Felipe Contreras wrote:
>> > Should these calls be pm_runtime_put_sync() instead of
>> > pm_runtime_put()?
>>
>> I don't see why... The thing failed, it's not going to be used any
>> more so better let PM deactivate the device.
>
> It's not a big deal.  The difference is that pm_runtime_put_sync()
> avoids an extra context switch when suspending the device.  A minor
> optimization, that's all.

Ok, I used what most of the code was using, but I've trusted you and
updated the patches. It would probably make sense to do the same in
other places.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/