linux-kernel - Re: [tip:x86/autoprobe] x86, cpufreq: Add support for x86 cpuinfo auto loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Dec 2011 11:12:01 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	ak@...ux.intel.com, tglx@...utronix.de, hpa@...ux.intel.com
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/autoprobe] x86, cpufreq: Add support for x86 cpuinfo
 auto loading


* tip-bot for Andi Kleen <ak@...ux.intel.com> wrote:

> Commit-ID:  c347c2092efcd7d4fc1575057db7a42c1fc15ec5
> Gitweb:     http://git.kernel.org/tip/c347c2092efcd7d4fc1575057db7a42c1fc15ec5
> Author:     Andi Kleen <ak@...ux.intel.com>
> AuthorDate: Mon, 19 Dec 2011 15:46:33 -0800
> Committer:  H. Peter Anvin <hpa@...ux.intel.com>
> CommitDate: Mon, 19 Dec 2011 15:50:01 -0800
> 
> x86, cpufreq: Add support for x86 cpuinfo auto loading

> diff --git a/drivers/cpufreq/gx-suspmod.c b/drivers/cpufreq/gx-suspmod.c
> index ffe1f2c..5a06c0b 100644
> --- a/drivers/cpufreq/gx-suspmod.c
> +++ b/drivers/cpufreq/gx-suspmod.c
> @@ -82,6 +82,7 @@
>  #include <linux/errno.h>
>  #include <linux/slab.h>
>  
> +#include <asm/cpu_device_id.h>
>  #include <asm/processor-cyrix.h>
>  
>  /* PCI config registers, all at F0 */
> @@ -171,6 +172,7 @@ static struct pci_device_id gx_chipset_tbl[] __initdata = {
>  	{ PCI_VDEVICE(CYRIX, PCI_DEVICE_ID_CYRIX_5510), },
>  	{ 0, },
>  };
> +MODULE_DEVICE_TABLE(gx_chipset_tbl);

Andi, you are sloppy as usual:

 drivers/cpufreq/gx-suspmod.c:175:35: error: macro "MODULE_DEVICE_TABLE" requires 2 arguments, but only 1 given

You have not even build tested this change?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/