linux-kernel - RE: [PATCH] davinci: DA850 EVM: OHCI platform code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Dec 2011 13:51:10 +0000
From:	"Gupta, Ajay Kumar" <ajay.gupta@...com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>,
	"Manjunathappa, Prakash" <prakash.pm@...com>
CC:	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH] davinci: DA850 EVM: OHCI platform code

Hi
> Hello.
> 
> On 20.12.2011 10:36, Manjunathappa, Prakash wrote:
> 
> > From: Ajay Kumar Gupta <ajay.gupta@...com>
> 
>     It's a good practice to CC the original author of the patch -- which
> I'm
> doing now...
> 
> > On this board the OHCI port's power control and over-current signals
> from
> > TPS2065 power switch are connected via GPIO1[15] and GPIO2[1]
> respectively,
> 
>     Ajay, your description seems to be copied unchganged from the
> analogous
> DA830 EVM patch, and thus doesn't match your patch: GPIO2[4] and
> GPIO6[13] are
> used apparently. Be more attentive to detail next time please.

Well, this patch was created long back for internal release work and
couldn't review this before it is sent out.

Prakash, Please correct the patch description as suggested.

Regards,
Ajay
> .
> > so we can implement the DA8xx OHCI glue layer's hooks for overriding
> the
> > root hub port's power and over-current status bits.
> 
> > We also have to properly set up the clocking mode in the CFGCHIP2
> register,
> > so that internal 24 MHz reference clock is fed to the USB 2.0 (MUSB)
> PHY and
> > its output is used to clock the USB 1.1 (OHCI) PHY...
> 
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@...com>
> > ---
> >   arch/arm/mach-davinci/board-da850-evm.c |  126
> +++++++++++++++++++++++++++++++
> >   1 files changed, 126 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-
> davinci/board-da850-evm.c
> > index 6659a90..df74ba5 100644
> > --- a/arch/arm/mach-davinci/board-da850-evm.c
> > +++ b/arch/arm/mach-davinci/board-da850-evm.c
> [...]
> > @@ -734,6 +736,127 @@ static struct davinci_i2c_platform_data
> da850_evm_i2c_0_pdata = {
> [...]
> > +static int da850_evm_usb_ocic_notify(da8xx_ocic_handler_t handler)
> > +{
> > +	int irq		= gpio_to_irq(ON_BD_USB_OVC);
> > +	int error	= 0;
> > +
> > +	if (handler != NULL) {
> > +		da850_evm_usb_ocic_handler = handler;
> > +
> > +		error = request_irq(irq, da850_evm_usb_ocic_irq,
> IRQF_DISABLED |
> 
>     IRQF_DISABLED is a nop now -- just remove it.
> 
> WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/