lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 20 Dec 2011 15:20:19 -0200
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Andrew Vagin <avagin@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	paulus@...ba.org, mingo@...e.hu, asharma@...com, devel@...nvz.org,
	dsahern@...il.com, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf: add ability to record event period

Em Tue, Dec 20, 2011 at 05:32:45PM +0300, Andrew Vagin escreveu:
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 766fa0a..f8fd14f 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -700,6 +700,7 @@ const struct option record_options[] = {
>  	OPT_BOOLEAN('d', "data", &record.opts.sample_address,
>  		    "Sample addresses"),
>  	OPT_BOOLEAN('T', "timestamp", &record.opts.sample_time, "Sample timestamps"),
> +	OPT_BOOLEAN('P', "period", &record.opts.period, "Sample period"),
>  	OPT_BOOLEAN('n', "no-samples", &record.opts.no_samples,
>  		    "don't sample"),
>  	OPT_BOOLEAN('N', "no-buildid-cache", &record.no_buildid_cache,

You forgot to update the tools/perf/Documentation/perf-record.txt tho.

I'm doing this for you this time, please take that into account next
time.

Regards and thanks for iterating thru this and working on perf!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ