linux-kernel - Re: [patch 4/5] x86, x2apic: allow "nox2apic" to disable x2apic mode setup by bios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Dec 2011 23:24:37 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	flyboy@...il.com
Subject: Re: [patch 4/5] x86, x2apic: allow "nox2apic" to disable x2apic mode
 setup by bios

On Wed, Dec 21, 2011 at 5:45 PM, Suresh Siddha
<suresh.b.siddha@...el.com> wrote:

> @@ -1453,12 +1462,17 @@ static void disable_x2apic(void)
>        if (msr & X2APIC_ENABLE) {
>                u32 x2apic_id = read_apic_id();
>
> -               if (x2apic_id > 255)
> -                       panic("Can not disable x2apic, id: %08x\n", x2apic_id);
> +               if (x2apic_id >= 255)
> +                       panic("Cannot disable x2apic, id: %08x\n", x2apic_id);

can not be applied cleanly.

update it a little bit.

need to use attached one to replace 4/5.

Thanks

Yinghai

View attachment "nox2apic_v10_4.patch" of type "text/x-patch" (3862 bytes)