linux-kernel - Re: [resend PATCH for 3.2] procfs: do not confuse jiffies with cputime64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Dec 2011 11:18:36 +0100
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Michal Hocko <mhocko@...e.cz>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org,
	"Artem S. Tashkinov" <t.artem@...lcity.com>,
	Dave Jones <davej@...hat.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [resend PATCH for 3.2] procfs: do not confuse jiffies with cputime64_t

Andrew Morton <akpm@...ux-foundation.org> writes:

> On Thu, 22 Dec 2011 01:14:39 +0100
> Andreas Schwab <schwab@...ux-m68k.org> wrote:
>
>> > a) what effect does this problem have upon users of the kernel?
>> 
>> get_idle_time returns the value in the wrong unit.
>
> So the "idle" fields in /proc/stat are wrong.
>
> We're getting there!  Now, in what way are they wrong?

They use the wrong unit, off by the factor between jiffies and cputime.

> How could a kernel maintainer recognise that this patch is needed?

By running the kernel on one of the architectures that are affected (did
I already say that on most architectures jiffies and cputime are
equivalent?).

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/