linux-kernel - Re: [PATCH V2 1/6] drivers/staging/ramster: cluster/messaging foundation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Dec 2011 09:31:29 -0800
From:	Greg KH <greg@...ah.com>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, ngupta@...are.org, konrad.wilk@...cle.com,
	kurt.hackel@...cle.com, sjenning@...ux.vnet.ibm.com,
	chris.mason@...cle.com
Subject: Re: [PATCH V2 1/6] drivers/staging/ramster: cluster/messaging
 foundation

On Thu, Dec 22, 2011 at 07:50:50AM -0800, Dan Magenheimer wrote:
> >From 93c00028709a5d423de77a2fc24d32ec10eca443 Mon Sep 17 00:00:00 2001
> From: Dan Magenheimer <dan.magenheimer@...cle.com>
> Date: Wed, 21 Dec 2011 14:01:54 -0700
> Subject: [PATCH V2 1/6] drivers/staging/ramster: cluster/messaging foundation

Why duplicate this in the email body?  That forces me to edit the
patches and remove them, please use git send-email...

> Copy cluster subdirectory from ocfs2.  These files implement
> the basic cluster discovery, mapping, heartbeat / keepalive, and
> messaging ("o2net") that ramster requires for internode communication.
> Note: there are NO ramster-specific changes yet; this commit
> does NOT pass checkpatch since the copied source files do not.

Why are you copying the files, and not just exporting the symbols you
need/want to use here?  Are you going to be able to properly track
keeping this code in sync?

Same goes for your other patch in this series that copies code, why do
that?  Are there goals to eventually not have duplicated code?  If so,
what are they, and why not mention them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/