linux-kernel - Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Dec 2011 11:44:16 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, security@...nel.org,
	pmatouse@...hat.com, agk@...hat.com, jbottomley@...allels.com,
	mchristi@...hat.com, msnitzer@...hat.com
Subject: Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices

On Thu, Dec 22, 2011 at 11:18 AM, Paolo Bonzini <pbonzini@...hat.com> wrote:
>>
>> This kind of crazy needs to go away.
>
> What crazy?  It's not a permission problem.  Sending a SCSI command to a
> partition makes no sense.  A permission problem implies that somehow you
> should be able to fix it by granting additional permissions, which is not
> the case here.

Ahh, I misread the intention here, and didn't notice that it was doing
it on the stupid SCSI ioctl commands, not the lowlevel SCSI "cmd". The
fact that the changelog talked about sending read/write commands down
to the disk confused me.

But please do use ENOIOCTLCMD directly then, instead of using ENOTTY
and turning it into ENOIOCTLCMD.

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/