linux-kernel - Re: loading firmware while usermodehelper disabled.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 Jan 2012 08:29:07 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Jack Stone <jwjstone@...tmail.fm>,
	Oliver Neukum <oliver@...kum.org>,
	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Larry Finger <Larry.Finger@...inger.net>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	"John W. Linville" <linville@...driver.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	USB list <linux-usb@...r.kernel.org>,
	Linux Wireless List <linux-wireless@...r.kernel.org>
Subject: Re: loading firmware while usermodehelper disabled.

On Tue, Jan 3, 2012 at 4:24 AM, Matthew Garrett <mjg@...hat.com> wrote:
>
> The IDs will have changed due to the firmware falling out.

The thing is, I don't think it has.

You said this used to work. And I suspect that the ID's haven't
changed at all. The unbind/rebind kind of supports that (it shouldn't
re-bind if it's not the same device, afaik). I suspect the bug report
is from a system that didn't actually have the firmware loaded even
before the suspend (so no USB ID changes, just the stupid
unbind/rebind).

Of course, it's possible that it "used to work" just because we used
to have that "we'll try to load things even if user space isn't
ready", which caused 30-second timeouts for the random cases where it
didn't work, but also silently "just worked" for the other random
cases where it did happen to work. But I don't think unbind/rebind is
correct for an ID change, so that really doesn't make sense as a
explanation either (at least for *this* particular bug report).

                         Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/