linux-kernel - Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Jan 2012 14:03:32 -0800
From:	Greg KH <gregkh@...e.de>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, alan@...ux.intel.com,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jiri Slaby <jirislaby@...il.com>
Subject: Re: [PATCH] serial: relocate remaining serial drivers from tty/ to
 tty/serial/

On Wed, Jan 04, 2012 at 04:07:52PM -0500, Paul Gortmaker wrote:
> On 12-01-04 03:51 PM, Greg KH wrote:
> > On Wed, Jan 04, 2012 at 09:34:36PM +0100, Jiri Slaby wrote:
> >> On 01/04/2012 09:01 PM, Paul Gortmaker wrote:
> >>>  rename drivers/tty/{ => serial}/amiserial.c (100%)
> >>>  rename drivers/tty/{ => serial}/cyclades.c (100%)
> >>>  rename drivers/tty/{ => serial}/isicom.c (100%)
> >>>  rename drivers/tty/{ => serial}/moxa.c (100%)
> >>>  rename drivers/tty/{ => serial}/moxa.h (100%)
> >>>  rename drivers/tty/{ => serial}/mxser.c (100%)
> >>>  rename drivers/tty/{ => serial}/mxser.h (100%)
> >>>  rename drivers/tty/{ => serial}/rocket.c (100%)
> >>>  rename drivers/tty/{ => serial}/rocket.h (100%)
> >>>  rename drivers/tty/{ => serial}/rocket_int.h (100%)
> >>>  rename drivers/tty/{ => serial}/synclink.c (100%)
> >>>  rename drivers/tty/{ => serial}/synclink_gt.c (100%)
> >>>  rename drivers/tty/{ => serial}/synclinkmp.c (100%)
> >>
> >> Hmm, tty/serial/* used to be for those using serial-core. And tty/ for
> >> those who don't. But FWIW I don't mind the change.
> > 
> > Yes, that is what I used when splitting them up, so this patch doesn't
> > make much sense.
> > 
> > Paul, why do you want these all mixed together?
> 
> My thinking was that having a drivers/tty/serial dir and then
> not having all the serial drivers in that dir violated the
> principle of least surprise.  Is there a reason why the dir should
> be the exclusive domain of drivers with a dependency on SERIAL_CORE?

Because that is what the directory is for?  :)

We have other "serial" like drivers all over the kernel, this was for
the SERIAL_CORE drivers only at the moment.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/