linux-kernel - Re: [PATCH 2/5] x86: efi: convert printk to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jan 2012 09:17:02 -0800
From:	Olof Johansson <olof@...om.net>
To:	Joe Perches <joe@...ches.com>
Cc:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Matthew Garrett <mjg@...hat.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH 2/5] x86: efi: convert printk to pr_*()

On Tue, Jan 3, 2012 at 9:26 PM, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2012-01-03 at 09:11 -0800, Olof Johansson wrote:
>> Alright, I guess I'll go through and convert them, even though
>> there's no net gain to speak of.
>
> Perhaps it'd be better to add
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include and remove PFX from the
> formats

I'm not sure it's much of a net gain, PFX was used only a couple of
times, the other printouts were just plain ones.

Anyway, I've switched to pr_fmt anyway, and reworded some of the
messages to not have redundant EFI's in them.

Thanks,

-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/