linux-kernel - Re: [PATCH 1/5] x86: efi: refactor efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jan 2012 13:00:45 -0800
From:	Olof Johansson <olof@...om.net>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH 1/5] x86: efi: refactor efi_init() a bit

On Thu, Jan 5, 2012 at 10:17 AM, Matthew Garrett <mjg59@...f.ucam.org> wrote:
> On Tue, Jan 03, 2012 at 09:11:18AM -0800, Olof Johansson wrote:
>
>>       if (memmap.desc_size != sizeof(efi_memory_desc_t))
>> -             printk(KERN_WARNING
>> -               "Kernel-defined memdesc doesn't match the one from EFI!\n");
>> +             printk(KERN_WARNING "Kernel-defined memdesc doesn't match the "
>> +                    "one from EFI!\n");
>
> Just kill this - it's valid per-spec, there's no reason for us to
> complain.
>
> Looks fine otherwise.

Sounds good, I removed it in v4.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/