linux-kernel - Re: [PATCH] scsi_dh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 Jan 2012 17:13:05 -0500
From:	Mike Snitzer <snitzer@...hat.com>
To:	Richard Weinberger <richard@....at>
Cc:	"Moger, Babu" <Babu.Moger@...app.com>, JBottomley@...allels.com,
	Somasundaram.Krishnasamy@....com, yanling.qi@....com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi_dh_rdac: Fix error path

On Sun, Dec 18, 2011 at 9:42 AM, Richard Weinberger <richard@....at> wrote:
> Am 18.11.2011 15:34, schrieb Moger, Babu:
>> Looks good to me..
>>
>>> -----Original Message-----
>>> From: Richard Weinberger [mailto:richard@....at]
>>> Sent: Thursday, November 17, 2011 6:44 PM
>>> To: JBottomley@...allels.com
>>> Cc: Moger, Babu; Somasundaram.Krishnasamy@....com; yanling.qi@....com;
>>> linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Richard
>>> Weinberger
>>> Subject: [PATCH] scsi_dh_rdac: Fix error path
>>>
>>> If create_singlethread_workqueue() failes, rdac_init should fail too.
>>>
>>> Signed-off-by: Richard Weinberger <richard@....at>
>>> ---
>>>  drivers/scsi/device_handler/scsi_dh_rdac.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c
>>> b/drivers/scsi/device_handler/scsi_dh_rdac.c
>>> index 1d31279..2802394 100644
>>> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
>>> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
>>> @@ -934,6 +934,8 @@ static int __init rdac_init(void)
>>>      if (!kmpath_rdacd) {
>>>              scsi_unregister_device_handler(&rdac_dh);
>>>              printk(KERN_ERR "kmpath_rdacd creation failed.\n");
>>> +
>>> +            r = -EINVAL;
>>>      }
>>>  done:
>>>      return r;
>>> --
>>> 1.7.7.3
>>
>
> James,
>
> can you please pickup this patch?

James, was this the one that you said was overlooked?

In any case, please apply, and for good measure:

Acked-by: Mike Snitzer <snitzer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/