linux-kernel - Re: [GIT PULL 05/11] SoC-level changes for tegra and omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Jan 2012 08:08:56 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Olof Johansson <olof@...om.net>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [GIT PULL 05/11] SoC-level changes for tegra and omap

On Tue, Jan 10, 2012 at 12:39 AM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
>
> What about using -C instead (which implies -M, but also detects copies) ?

I don't mind -C. It sometimes causes differences to what I see by
default, but those differences are often interesting.

But while it's interesting and relevant (unlike the non-rename patch
that is just noisy), it also can hide lots of lines. With -C, you can
get a diffstat that is actually fairly small, but that adds a lot of
lines to the kernel (because somebody just copied large files with
small changes), and if that happens I do want to see it as a "big
change". So for me, the plain "just show renames" is a good default.

So there is absolutely nothing wrong with -C. It's not what I use, but
when I see that the diffstats don't match, it's easy to notice why,
and that information is often fairly interesting, so I don't mind.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/